Don't strictly require inih #490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inih isn't used by anything in liblcf directly, relaxing this requirement and allowing it to be disabled enables outside projects to more easily integrate this library into their application. This PR enables this while still making it the default, so the current behavior is the default one requiring no changes in existing apps (easyrpg-player)
Member
|
Thanks that looks like a reasonable change. Will look at it during the weekend. |
Exclude inih from CMake config file when disabled.
0c57f77 to
8c4f207
Compare
Ghabry
approved these changes
Jan 6, 2025
Member
|
Jenkins: test this please Strange WiiU build error o_O ... lets try again. |
Contributor
Author
|
Somehow I missed a few references and they cropped up when I started integrating it. |
Contributor
Author
|
What the heck? I literally just built it on linux o.0 |
1750cc7 to
d180eaa
Compare
d180eaa to
90ac4e8
Compare
Contributor
Author
|
Well that was an ordeal, but everything should be in order now. lcf2xml was being naughty and threw off my assumption lol |
Member
|
more junk for autotools was missing... should be fine now. :) |
carstene1ns
reviewed
Jan 8, 2025
Member
|
Okay i think all are happy now. Dependency changes are always a bit annoying to code 😅 |
Contributor
Author
|
Yeah, having to deal with it in my own projects gives me that understanding as well lol. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inih isn't used by anything in liblcf directly, relaxing this requirement and allowing it to be disabled enables outside projects to more easily integrate this library into their application.
This PR enables this while still making inih a default requirement, so the current behavior is the default one requiring no changes in existing apps (easyrpg-player)