Maniacs Feature: Add separate Width/Height parameters for scaling pictures #473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hi and thanks for the contribution. I'm currently on vacation. Will take a look at it in January. |
Contributor
Author
|
I've changed the pointers so that width uses the same as "magnify", and height uses 0A and 24 for current and finish respectively. |
Updated width and height chunk pointers - current_scale_height set to 0A - finish_scale_height set to 24
Member
|
jenkins: test this please <3 |
Ghabry
approved these changes
Mar 25, 2024
fdelapena
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the following lines inside fields_easyrpg.csv:
This is in preparation for adding Width/Height support into EasyRPG.