Skip to content

Migrate to std::string_view, liblcf #495 #3360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Ghabry merged 5 commits into from
Mar 20, 2025
Merged

Migrate to std::string_view, liblcf #495 #3360

Ghabry merged 5 commits into from
Mar 20, 2025

Conversation

@Ghabry
Copy link
Member

@Ghabry Ghabry commented Mar 2, 2025

The StartsWith/EndsWith needed manual work, rest was Search/Replace.

@Ghabry Ghabry added this to the 0.8.1 milestone Mar 2, 2025
@github-actions github-actions bot added Android Window/Scenes FileFinder Bitmaps Audio Fonts Battle Emscripten WebAssembly/JavaScript port for web browsers 3DS Nintendo 3DS Homebrew Tests MIDI Messages Settings All about customizable features, storing and applying them Input Input related (gamepads, keyboard mappings, mouse support). For KeyInputProc, add event/interpreter Translation labels Mar 2, 2025
@Ghabry Ghabry removed Android Window/Scenes FileFinder Bitmaps Audio Fonts Battle Emscripten WebAssembly/JavaScript port for web browsers 3DS Nintendo 3DS Homebrew Tests MIDI Messages Settings All about customizable features, storing and applying them labels Mar 2, 2025
@Ghabry Ghabry added Has PR Dependencies This PR depends on another PR and removed Input Input related (gamepads, keyboard mappings, mouse support). For KeyInputProc, add event/interpreter Translation labels Mar 2, 2025
florianessl
florianessl reviewed Mar 9, 2025
View reviewed changes
@Ghabry Ghabry force-pushed the stringview branch 2 times, most recently from 63b5302 to 4fa6d98 Compare March 10, 2025 12:04
@Ghabry
Copy link
Member Author

Ghabry commented Mar 10, 2025

@florianessl can you do a compile (a short functionality test) on Windows again?

I already tested config reading/writing with ASAN enabled on Linux so it should work ™️

@florianessl
Copy link
Member

florianessl commented Mar 10, 2025

@florianessl can you do a compile (a short functionality test) on Windows again?

I already tested config reading/writing with ASAN enabled on Linux so it should work ™️

Already have!
MSVC build went through without complaint & everything seems to work out fine for my test games here. 👍

@Ghabry Ghabry removed the Has PR Dependencies This PR depends on another PR label Mar 20, 2025
@Ghabry Ghabry merged commit 857af8e into EasyRPG:master Mar 20, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fdelapena fdelapena fdelapena approved these changes

+1 more reviewer

@florianessl florianessl florianessl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

0.8.1

Development

Successfully merging this pull request may close these issues.

3 participants

@Ghabry @florianessl @fdelapena