Skip to content

FlashEvent - Maniac Patch Parameters #3329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Ghabry merged 1 commit into from
Jan 14, 2025
Merged

FlashEvent - Maniac Patch Parameters #3329

Ghabry merged 1 commit into from
Jan 14, 2025

Conversation

@jetrotal
Copy link
Contributor

@jetrotal jetrotal commented Jan 7, 2025 •
edited
Loading

Supporting usage of variables when game uses maniac patch
and parameters size is bigger than 7.

//TPC Example
@ev.flash .player .rgbv v[100], v[101], v[102], v[103] .time 100

@Ghabry
Copy link
Member

Ghabry commented Jan 8, 2025 •
edited
Loading

You can use the other overload of ValueOrVariableBitfield which does already do the Maniac and size checking:

int event_id = VariableOrVariableBitfield(com, 7, 0, 0);
// and so on...

See PlayBGM:

Player/src/game_interpreter.cpp

Lines 1978 to 1989 in 7976386

bool Game_Interpreter::CommandPlayBGM(lcf::rpg::EventCommand const& com) { // code 11510
lcf::rpg::Music music;
music.name = ToString(CommandStringOrVariableBitfield(com, 4, 0, 5));
music.fadein = ValueOrVariableBitfield(com, 4, 1, 0);
music.volume = ValueOrVariableBitfield(com, 4, 2, 1);
music.tempo = ValueOrVariableBitfield(com, 4, 3, 2);
music.balance = ValueOrVariableBitfield(com, 4, 4, 3);
Main_Data::game_system->BgmPlay(music);
return true;
}

@Ghabry Ghabry added this to the 0.8.1 milestone Jan 8, 2025
@jetrotal
FlashEvent - Maniac Patch Parameters
eeaeb81 
Supporting usage of variables when
game uses maniac patch
and parameters size is bigger than 7.

Update game_interpreter_map.cpp
@jetrotal jetrotal force-pushed the maniacs-FlashEvent branch from c5b60b4 to eeaeb81 Compare January 8, 2025 10:16
@Ghabry Ghabry merged commit ea2f6c0 into EasyRPG:master Jan 14, 2025
13 checks passed
@jetrotal jetrotal deleted the maniacs-FlashEvent branch December 15, 2025 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ghabry Ghabry Ghabry approved these changes

Assignees

No one assigned

Labels

Event/Interpreter RPG_RT Patches

Milestone

0.8.1

Development

Successfully merging this pull request may close these issues.

2 participants

@jetrotal @Ghabry