Skip to content

Implemented Maniacs Command 3010: ControlATBGauge #3291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Ghabry merged 4 commits into from
Nov 9, 2024
Merged

Implemented Maniacs Command 3010: ControlATBGauge #3291

Ghabry merged 4 commits into from
Nov 9, 2024

Conversation

@MakoInfused
Copy link
Contributor

@MakoInfused MakoInfused commented Nov 7, 2024

Using the maniacs patch ControlATBGauge with something like this:
image

Will result in all party members having 1/3rd of a full gauge.
image

Or using it with 100% ATB for the first party member:
image

Would result in this:
image

Of course developers can use any combination of parameters, I've tested all of them individually with all combinations.

I've also recreated the functionality from maniacs where when a 0 index is passed in as an actor id, it just ignores the command entirely.

@Ghabry Ghabry added Battle Has PR Dependencies This PR depends on another PR and removed Window/Scenes Building labels Nov 7, 2024
@Ghabry Ghabry added this to the 0.8.1 milestone Nov 7, 2024
Ghabry
Ghabry requested changes Nov 7, 2024
View reviewed changes
@MakoInfused MakoInfused requested a review from Ghabry November 7, 2024 12:35
@Ghabry Ghabry removed the Has PR Dependencies This PR depends on another PR label Nov 8, 2024
@Ghabry
Copy link
Member

Ghabry commented Nov 8, 2024

Please rebase to get rid of the merge commits:

git remote add upstream https://github.com/easyrpg/player
git fetch upstream

git rebase upstream/master

Solve merge conflicts (if there are any) 
Then check with git log that the history looks okay

git push --force-with-lease origin

@MakoInfused MakoInfused force-pushed the ManiacControlATBGauge branch from 3a29899 to 4d3feae Compare November 8, 2024 10:25
@Ghabry
Copy link
Member

Ghabry commented Nov 8, 2024

Rebase result looks good 👍

@Ghabry Ghabry mentioned this pull request Nov 8, 2024
Open
27 tasks
Ghabry
Ghabry reviewed Nov 8, 2024
View reviewed changes
Ghabry
Ghabry reviewed Nov 8, 2024
View reviewed changes
@MakoInfused MakoInfused requested a review from Ghabry November 9, 2024 04:33
Ghabry
Ghabry reviewed Nov 9, 2024
View reviewed changes
Ghabry
Ghabry approved these changes Nov 9, 2024
View reviewed changes
Copy link
Member

@Ghabry Ghabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the warning is fixed looks good to me

@Ghabry Ghabry merged commit 6331bb8 into EasyRPG:master Nov 9, 2024
@MakoInfused MakoInfused deleted the ManiacControlATBGauge branch December 13, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fdelapena fdelapena fdelapena approved these changes

@Ghabry Ghabry Ghabry approved these changes

Assignees

No one assigned

Labels

Battle Event/Interpreter RPG_RT Patches

Milestone

0.8.1

Development

Successfully merging this pull request may close these issues.

3 participants

@MakoInfused @Ghabry @fdelapena