Skip to content

Conversation

@gameblabla
Copy link
Contributor

If either of these is disabled in a Makefile, then it will result in errors during compiling.

@carstene1ns
Copy link
Member

This should not really be necessary, since the used functions have these guards as well.
Do you get the errors from the config stuff?

@carstene1ns carstene1ns added the Needs feedback Waiting for the issue author to give further information. label Aug 11, 2024
@gameblabla
Copy link
Contributor Author

I did not try the cmake but i was trying with the old makefile and disabling WildMidi and fluidsynth and i was getting those errors otherwise (when not left enabled). Pretty clear to me looking at the rest of this file in question that this is not the only place where fluidsynth code... is being encapsulated behind ifdefs.

@gameblabla
Copy link
Contributor Author

I checked with Fluidlite and i have not fixed all issues...

../../src/audio_midi.cpp:55:13: error: ‘Audio’ was not declared in this scope
   55 |         if (Audio().GetFluidsynthEnabled()) {

This happens if the resampler is not enabled but fluidlite or fluidsynth are. Don't merge this yet, i will address this issue.

@carstene1ns
Copy link
Member

With the moved included file is the rest still needed?

@Ghabry
Copy link
Member

Ghabry commented Aug 25, 2024

For me this works just with the relocated include.

@Ghabry Ghabry removed the Needs feedback Waiting for the issue author to give further information. label Aug 25, 2024
@Ghabry Ghabry changed the title Fix compilation errors when FluidSynth/WildMidi/FMMidi are disabled Fix compilation errors when Resamping iss disabled Aug 25, 2024
@Ghabry Ghabry changed the title Fix compilation errors when Resamping iss disabled Fix compilation errors when Resamping is disabled Aug 25, 2024
@Ghabry Ghabry added this to the 0.8.1 milestone Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants