Maniacs Feature - Remove scaling restrictions for pictures #3249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From Maniac Patch version 240423: [RPG_RT.exe] Support for different magnification rates for special drawing of pictures (rotation, waveform, angle). + Added check if sprite's width/height is at zero. If so, skip the draw routine (helps avoid a glitchy sprite at the top-left when rotating an infinitely thin picture) - Removed check for effect mode when setting zoom or width/height. One thing to note when comparing Maniac and EasyRPG: the former doesn't seem to properly clip the sprite in the corners, when rotating the sprite.
Member
|
I'm sorry for the lack of feedback on your PRs. We appreciate the contribution. The project activity is usually reduced during summer because of vacation. I will review your code in September. Thank you for your patience. |
fdelapena
approved these changes
Aug 30, 2024
Ghabry
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From Maniac Patch version 240423:
One thing to note when comparing Maniac and EasyRPG: the former doesn't seem to properly clip the sprite in the corners when rotating the sprite.