Maniac: Implement CallCommand and String Vars #3140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 tasks
fdelapena
approved these changes
Oct 30, 2023
Member
Author
|
Pending final change that depends on #3141 if (com.parameters.size() >= 5) {
cmd.string = Main_Data::game_strings->GetWithModeBitfield(com.string, com.parameters[0], 3, com.parameters[4]);
} else {
cmd.string = com.string;
}btw, such code will be also needed for other commands just with a different index: if (Player::IsPatchManiac() && com.parameters.size() >= A) {
cmd.string = Main_Data::game_strings->GetWithModeBitfield(com.string, com.parameters[0], B, com.parameters[A - 1]);
} else {
cmd.string = com.string;
}Could need a helper function 🤔 |
3132d80 to
ed2ee73
Compare
Makes implementing string variables for command simpler.
ed2ee73 to
d37387e
Compare
Member
Author
|
I added variable lookup to commands that support this with Maniac Patch. Please review carefully that I did not mess up the numbers. |
Gives Maniac indirection support to all commands that use this function.
d37387e to
a03f508
Compare
(Fortunately the hard part of this was already solved)
Is irrelevant for us and results in output spam
fdelapena
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.