Improve JS MIME type detection #273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhances the `_setContentTypeFromPath` method in `AsyncFileResponse` to better handle JavaScript MIME types. Previously, `.js` files were correctly recognized, but `.mjs` files (ES modules) were not and defaulted to `application/javascript`. This enhancement ensures both `.js` and `.mjs` files are assigned `text/javascript`, improving compatibility with modern browsers. All other MIME type handling remains unchanged. This change enhances robustness and standards compliance of the file server. Fix the issue ESP32Async#267
mathieucarbou
approved these changes
Aug 22, 2025
me-no-dev
approved these changes
Aug 22, 2025
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhances the
_setContentTypeFromPathmethod inAsyncFileResponseto better handle JavaScript MIME types.Previously,
.jsfiles were correctly recognized, but.mjsfiles (ES modules) were not and defaulted toapplication/javascript. This enhancement ensures both.jsand.mjsfiles are assignedtext/javascript, improving compatibility with modern browsers.All other MIME type handling remains unchanged. This change enhances robustness and standards compliance of the file server.
Fix the issue #267