Add Content-Type for MP4 files #234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch ensures that HTTP responses serving .mp4 files include the correct Content-Type: video/mp4 header. This improves media compatibility across browsers and clients, and adheres to standard MIME type conventions for MP4 files. No changes were made outside of content-type handling for MP4. If the correct content type is not sent, many browsers will ignore the Content-Disposition: inline header and download the file instead of playing it in-browser. In such cases, the browser assumes it cannot render the content inline and defaults to download behavior. This fix ensures MP4 files are properly recognized and played directly in the browser when expected.
5 tasks
mathieucarbou
approved these changes
Jul 18, 2025
me-no-dev
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch ensures that HTTP responses serving .mp4 files include the correct Content-Type: video/mp4 header. This improves media compatibility across browsers and clients, and adheres to standard MIME type conventions for MP4 files. No changes were made outside of content-type handling for MP4.
If the correct content type is not sent, many browsers will ignore the Content-Disposition: inline header and download the file instead of playing it in-browser. In such cases, the browser assumes it cannot render the content inline and defaults to download behavior. This fix ensures MP4 files are properly recognized and played directly in the browser when expected.