-
Notifications
You must be signed in to change notification settings - Fork 44
Avoid copying input data in CMIP6 CESM2 air pressure level fixes #2454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
very cool @bouweandela 👏 Always nice to see data transfer optimizations, hope you don't mind me turning on the GA see if any issues for older Pythons - I took a look at the failed tests - couple of them due to mocks not called (easy fix) but one fails due to what looks to be a reversal of the lev bounds, can prob fix that for you here, if you don't have time 🍺 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2454 +/- ##
=======================================
Coverage 94.77% 94.78%
=======================================
Files 251 251
Lines 14266 14292 +26
=======================================
+ Hits 13520 13546 +26
Misses 746 746 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Enable lock sharing between ncdata and Iris Suppress load warnings Restore lat/lon coord units after load All fixes in fix_file
|
TODO: move to new What about chunking? |
|
In order to maintain a backlog of relevant pull requests, we automatically label them as stale after 180 days of inactivity. If this pull request is still important to you, please comment below to remove the stale label. Otherwise, this pull request will be automatically closed in 60 days. If this pull request only suffers from a lack of reviewers, please tag the @ESMValGroup/technical-lead-development-team so they can help you find a suitable reviewer. |
|
This stale pull request has been automatically closed due to a lack of community activity. If you still care about this pull request, please re-open it. If you do not have sufficient permissions for this, tag the @ESMValGroup/technical-lead-development-team in a comment below including a short message that this pull request is still relevant to you. They will re-open it on your behalf. |
Description
Use ncdata to fix files in-memory instead of copies on disk.
Related to #2129 and #674
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: