Skip to content

[Cleanup] Cleanup #show ip_lookup Message#5005

Merged
Kinglykrab merged 3 commits intomasterfrom
cleanup/show_ip_lookup
Aug 30, 2025
Merged

[Cleanup] Cleanup #show ip_lookup Message#5005
Kinglykrab merged 3 commits intomasterfrom
cleanup/show_ip_lookup

Conversation

@Kinglykrab
Copy link
Copy Markdown
Contributor

@Kinglykrab Kinglykrab commented Aug 29, 2025 •
edited
Loading

Description

  • Cleans up the #show ip_lookup message.
  • Also fixes an issue where we were adding 1 to the size and query length of the packet, causing data corruption.

Checklist

  • I have tested my changes
  • I have performed a self-review of my code. Ensuring variables, functions and methods are named in a human-readable way, comments are added only where naming of variables, functions and methods can't give enough context.
  • I own the changes of my code and take responsibility for the potential issues that occur

@Kinglykrab
Copy link
Copy Markdown
Contributor Author

Kinglykrab commented Aug 30, 2025

Not sure why Windows is failing here, I didn't change anything related to ZoneDatabase.

@joligario
Copy link
Copy Markdown
Contributor

joligario commented Aug 30, 2025 •
edited
Loading

Not sure why Windows is failing here, I didn't change anything related to ZoneDatabase.

Issue is in the saylinks

Severity	Code	Description	Project	File	Line	Suppression State	Details
Error	LNK2001	unresolved external symbol "class ZoneDatabase database" (?database@@3VZoneDatabase@@A)	world	C:\Users\jolig\Downloads\Everquest\eqemu\build\world\common.lib(say_link.obj)	1

@Kinglykrab
Copy link
Copy Markdown
Contributor Author

Kinglykrab commented Aug 30, 2025

Not sure why Windows is failing here, I didn't change anything related to ZoneDatabase.

Issue is in the saylinks

Severity	Code	Description	Project	File	Line	Suppression State	Details
Error	LNK2001	unresolved external symbol "class ZoneDatabase database" (?database@@3VZoneDatabase@@A)	world	C:\Users\jolig\Downloads\Everquest\eqemu\build\world\common.lib(say_link.obj)	1

Yeah, still unsure why Linux would be cool with it, but Windows isn't.

@Kinglykrab
Copy link
Copy Markdown
Contributor Author

Kinglykrab commented Aug 30, 2025

Removed the saylinks.

@joligario
Copy link
Copy Markdown
Contributor

joligario commented Aug 30, 2025

The FMT formattings were still good if you wanted those in there.

@Kinglykrab
Copy link
Copy Markdown
Contributor Author

Kinglykrab commented Aug 30, 2025

The FMT formattings were still good if you wanted those in there.

They were only there for the the saylink value.

@Kinglykrab Kinglykrab merged commit 822a5dc into master Aug 30, 2025
2 checks passed
@Kinglykrab Kinglykrab deleted the cleanup/show_ip_lookup branch August 30, 2025 17:05
@joligario joligario mentioned this pull request Sep 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joligario joligario joligario approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Kinglykrab @joligario