Skip to content

[Constants] Convert SE Defines to SpellEffect Namespace#4999

Merged
Kinglykrab merged 1 commit intomasterfrom
constants/se_to_spelleffect_constants
Aug 30, 2025
Merged

[Constants] Convert SE Defines to SpellEffect Namespace#4999
Kinglykrab merged 1 commit intomasterfrom
constants/se_to_spelleffect_constants

Conversation

@Kinglykrab
Copy link
Copy Markdown
Contributor

@Kinglykrab Kinglykrab commented Aug 28, 2025

Description

  • Converts all SE_ constants like SE_X to use namespace SpellEffect like SpellEffect::X.

Checklist

  • I have tested my changes
  • I have performed a self-review of my code. Ensuring variables, functions and methods are named in a human-readable way, comments are added only where naming of variables, functions and methods can't give enough context.
  • I own the changes of my code and take responsibility for the potential issues that occur

@Kinglykrab Kinglykrab merged commit 060f6e3 into master Aug 30, 2025
2 checks passed
@Kinglykrab Kinglykrab deleted the constants/se_to_spelleffect_constants branch August 30, 2025 19:33
@joligario joligario mentioned this pull request Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants