Skip to content

[Repositories] Convert Spell Loading to Repositories#4996

Merged
Kinglykrab merged 1 commit intomasterfrom
repositories/spell_loading
Aug 30, 2025
Merged

[Repositories] Convert Spell Loading to Repositories#4996
Kinglykrab merged 1 commit intomasterfrom
repositories/spell_loading

Conversation

@Kinglykrab
Copy link
Copy Markdown
Contributor

Description

  • Converts uses of spells_new in shareddb.cpp to use repositories.
  • This will require a change to tools like Spire, PEQ Editor, and any other tool that directly uses field names because there are several columns that were not named according to the way they're used in the source.

The following columns were renamed:
field160 to feedbackable
field198 to no_detrimental_spell_aggro
field209 to no_resist
field217 to override_crit_chance
field220 to no_heal_damage_item_mod
field221 to caster_requirement_id
field222 to spell_class
field223 to spell_subclass
field232 to no_remove

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing

Spell Loading Confirmed Working and Heal Working
image

With Temperance
image

Without Temperance
image

Checklist

  • I have tested my changes
  • I have performed a self-review of my code. Ensuring variables, functions and methods are named in a human-readable way, comments are added only where naming of variables, functions and methods can't give enough context.
  • (Once merged) I have made corresponding changes to the documentation (if applicable, if not delete this line)
  • I own the changes of my code and take responsibility for the potential issues that occur
  • If my changes make database schema changes, I have tested the changes on a local database (attach image). Updated version.h CURRENT_BINARY_DATABASE_VERSION to the new version. (Delete this if not applicable)

@Kinglykrab Kinglykrab force-pushed the repositories/spell_loading branch from a9748c0 to 6de181b Compare August 30, 2025 19:32
@Kinglykrab Kinglykrab merged commit ba78394 into master Aug 30, 2025
2 checks passed
@Kinglykrab Kinglykrab deleted the repositories/spell_loading branch August 30, 2025 19:42
joligario added a commit to ProjectEQ/peqphpeditor that referenced this pull request Sep 14, 2025
@joligario joligario mentioned this pull request Sep 15, 2025
Akkadius added a commit that referenced this pull request Sep 17, 2025
joligario added a commit to ProjectEQ/peqphpeditor that referenced this pull request Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants