Skip to content

[Build] Fix Linking with GCC#4969

Merged
Akkadius merged 1 commit intoEQEmu:masterfrom
solar984:upstream
Aug 3, 2025
Merged

[Build] Fix Linking with GCC#4969
Akkadius merged 1 commit intoEQEmu:masterfrom
solar984:upstream

Conversation

@solar984
Copy link
Copy Markdown
Contributor

Description

When building with gcc instead of clang, the order of items passed for final linking matters and it was failing with undefined symbols since the unity build for lua was added. I rearranged the items in the cmake file and tested rebuilding with both clang and gcc.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Testing

I tested on debian with the following versions:
Debian clang version 14.0.6
gcc version 12.2.0 (Debian 12.2.0-14+deb12u1)

Clients tested: N/A

Checklist

  • I have tested my changes
  • I have performed a self-review of my code. Ensuring variables, functions and methods are named in a human-readable way, comments are added only where naming of variables, functions and methods can't give enough context.
  • I own the changes of my code and take responsibility for the potential issues that occur

@Akkadius Akkadius changed the title fix linking with gcc [Build] Fix Linking with GCC Aug 3, 2025
@Akkadius Akkadius merged commit ffa813b into EQEmu:master Aug 3, 2025
1 check passed
@Akkadius Akkadius mentioned this pull request Aug 3, 2025
@solar984 solar984 deleted the upstream branch August 5, 2025 05:52
@joligario joligario mentioned this pull request Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants