Skip to content

[Code] TaskManager Global to Singleton Cleanup#4945

Merged
Kinglykrab merged 3 commits intomasterfrom
kinglykrab/taskmanager-global-to-singleton
Jun 22, 2025
Merged

[Code] TaskManager Global to Singleton Cleanup#4945
Kinglykrab merged 3 commits intomasterfrom
kinglykrab/taskmanager-global-to-singleton

Conversation

@Kinglykrab
Copy link
Copy Markdown
Contributor

@Kinglykrab Kinglykrab commented Jun 21, 2025

Description

This is part of a larger effort to remove global variables from the codebase. Eventually singletons can be cleaned up to be passed explicitly through dependency injection.

For now this encapsulates dependencies far better.

Type of change

  • Code Cleanup

Testing

image
image

Checklist

  • I have tested my changes
  • I have performed a self-review of my code. Ensuring variables, functions and methods are named in a human-readable way, comments are added only where naming of variables, functions and methods can't give enough context.
  • I own the changes of my code and take responsibility for the potential issues that occur

Copy link
Copy Markdown
Member

@KimLS KimLS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't have to test for existence if we make this a singleton but its whatever.

@Kinglykrab Kinglykrab merged commit 940f97c into master Jun 22, 2025
2 checks passed
@Kinglykrab Kinglykrab deleted the kinglykrab/taskmanager-global-to-singleton branch June 22, 2025 18:10
@Akkadius Akkadius mentioned this pull request Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants