Skip to content

[Code] SkillCaps Global to Singleton Cleanup#4933

Merged
Kinglykrab merged 1 commit intomasterfrom
kinglykrab/skillcaps-global-to-singleton
Jun 22, 2025
Merged

[Code] SkillCaps Global to Singleton Cleanup#4933
Kinglykrab merged 1 commit intomasterfrom
kinglykrab/skillcaps-global-to-singleton

Conversation

@Kinglykrab
Copy link
Copy Markdown
Contributor

@Kinglykrab Kinglykrab commented Jun 21, 2025

Description

This is part of a larger effort to remove global variables from the codebase. Eventually singletons can be cleaned up to be passed explicitly through dependency injection.

For now this encapsulates dependencies far better.

Type of change

  • Code Cleanup

Testing

image

Checklist

  • I have tested my changes
  • I have performed a self-review of my code. Ensuring variables, functions and methods are named in a human-readable way, comments are added only where naming of variables, functions and methods can't give enough context.
  • I own the changes of my code and take responsibility for the potential issues that occur

@Kinglykrab Kinglykrab merged commit 2f4a5b5 into master Jun 22, 2025
2 checks passed
@Kinglykrab Kinglykrab deleted the kinglykrab/skillcaps-global-to-singleton branch June 22, 2025 18:13
@Akkadius Akkadius mentioned this pull request Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants