Skip to content

[Code] WorldEventScheduler and ZoneEventScheduler Global to Singleton Cleanup#4932

Merged
Akkadius merged 1 commit intomasterfrom
kinglykrab/worldeventscheduler-zoneeventscheduler-global-to-singleton
Jun 25, 2025
Merged

[Code] WorldEventScheduler and ZoneEventScheduler Global to Singleton Cleanup#4932
Akkadius merged 1 commit intomasterfrom
kinglykrab/worldeventscheduler-zoneeventscheduler-global-to-singleton

Conversation

@Kinglykrab
Copy link
Copy Markdown
Contributor

Description

This is part of a larger effort to remove global variables from the codebase. Eventually singletons can be cleaned up to be passed explicitly through dependency injection.

For now this encapsulates dependencies far better.

Type of change

  • Code Cleanup

Testing

TBD

Checklist

  • [] I have tested my changes
  • I have performed a self-review of my code. Ensuring variables, functions and methods are named in a human-readable way, comments are added only where naming of variables, functions and methods can't give enough context.
  • I own the changes of my code and take responsibility for the potential issues that occur

@Akkadius Akkadius force-pushed the kinglykrab/worldeventscheduler-zoneeventscheduler-global-to-singleton branch from 029b376 to 3c03641 Compare June 25, 2025 19:44
@Akkadius
Copy link
Copy Markdown
Contributor

Manually rebased and built

@Akkadius Akkadius merged commit 967a13e into master Jun 25, 2025
0 of 2 checks passed
@Akkadius Akkadius deleted the kinglykrab/worldeventscheduler-zoneeventscheduler-global-to-singleton branch June 25, 2025 19:47
@Akkadius Akkadius mentioned this pull request Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants