Skip to content

[Code] EQEmuLogSys Global to Singleton Cleanup#4925

Merged
Akkadius merged 3 commits intomasterfrom
akkadius/logsys-global-to-singleton
Jun 25, 2025
Merged

[Code] EQEmuLogSys Global to Singleton Cleanup#4925
Akkadius merged 3 commits intomasterfrom
akkadius/logsys-global-to-singleton

Conversation

@Akkadius
Copy link
Copy Markdown
Contributor

@Akkadius Akkadius commented Jun 21, 2025

Description

This is part of a larger effort to remove global variables from the codebase. Eventually singletons can be cleaned up to be passed explicitly through dependency injection.

For now this encapsulates dependencies far better.

Type of change

  • Code Cleanup

Testing

Booted up processes and logging works all the same

Checklist

  • I have tested my changes
  • I have performed a self-review of my code. Ensuring variables, functions and methods are named in a human-readable way, comments are added only where naming of variables, functions and methods can't give enough context.
  • I own the changes of my code and take responsibility for the potential issues that occur

@Akkadius Akkadius merged commit 947795f into master Jun 25, 2025
0 of 2 checks passed
@Akkadius Akkadius deleted the akkadius/logsys-global-to-singleton branch June 25, 2025 19:05
@Akkadius Akkadius mentioned this pull request Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants