Skip to content

[Quest API] Add CompleteTask and UncompleteTask methods to Perl/Lua#4921

Merged
Akkadius merged 10 commits intoEQEmu:masterfrom
Barathos:bems_changes
Jun 25, 2025
Merged

[Quest API] Add CompleteTask and UncompleteTask methods to Perl/Lua#4921
Akkadius merged 10 commits intoEQEmu:masterfrom
Barathos:bems_changes

Conversation

@Barathos
Copy link
Copy Markdown
Contributor

@Barathos Barathos commented Jun 17, 2025

Description

Adds a client-specific complete and uncomplete task method as well as a general quest method one.

Dependencies:
No new external dependencies introduced.

Perl

  • Add $client->CompleteTask(task_id)
  • Add $client->UncompleteTask(task_id)
  • Add quest::completetask(task_id)
  • Add quest::uncompletetask(task_id)

Lua

  • Add client:CompleteTask(task_id)
  • Add client:UncompleteTask(task_id)
  • Add eq.completetask(task_id)
  • Add eq.uncompletetask(task_id)

Type of change

  • New feature (non-breaking change which adds functionality)

Testing

The new uncompletetask method was tested by:

  • Adding test scripts using both Perl and Lua APIs.
  • Triggering the function from an in-game NPC script to ensure tasks were correctly marked as incomplete for a client.
  • Verifying quest progression and player task state changes in-game.
  • No regressions observed in other quest APIs or standard quest functionality.

Clients tested:

  • ROF2

See attached images for sample test output and scripts (attach relevant screenshots if possible).
image

Checklist

  • I have tested my changes
  • I have performed a self-review of my code. Ensuring variables, functions and methods are named in a human-readable way, comments are added only where naming of variables, functions and methods can't give enough context.
  • I have made corresponding changes to the documentation (if applicable, if not delete this line)
  • I own the changes of my code and take responsibility for the potential issues that occur

@Kinglykrab Kinglykrab changed the title [Quest API] Add uncompletetask method to Perl/LUA [WIP] [Quest API] Add CompleteTask and UncompleteTask methods to Perl/LUA Jun 20, 2025
@Kinglykrab Kinglykrab changed the title [Quest API] Add CompleteTask and UncompleteTask methods to Perl/LUA [Quest API] Add CompleteTask and UncompleteTask methods to Perl/Lua Jun 20, 2025
Copy link
Copy Markdown
Contributor

@Akkadius Akkadius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@Akkadius Akkadius merged commit 46b43a9 into EQEmu:master Jun 25, 2025
1 check passed
@Akkadius Akkadius mentioned this pull request Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants