[Player Events] Zone Fetch Settings from QS if Enabled#4915
Merged
Conversation
joligario
approved these changes
Jun 11, 2025
KimLS
approved these changes
Jun 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When large servers have high player event log volume, they can choose to offload player events to another server (QueryServ) where it has a separate logging database and server entirely.
The problem with this is that player event log settings can become split brained because the settings are authoritative on QS (log server). The zone server loads settings locally instead of pulling them from QS. This PR addresses that by having QS send settings when zone initially connects.
When #reload or Spire reload requests are issued, when the rule Logging:PlayerEventsQSProcess is enabled, zones will instead reload from QS instead of reloading from their local.
Type of change
Testing
When zones boot, they fetch settings from QS when Logging:PlayerEventsQSProcess is enabled
This is when log settings are reloaded either from in game or from Spire
Checklist