Skip to content

[Player Events] Don't Write Empty Data#4912

Merged
joligario merged 4 commits intomasterfrom
akkadius/player-event-save-space
Jun 25, 2025
Merged

[Player Events] Don't Write Empty Data#4912
joligario merged 4 commits intomasterfrom
akkadius/player-event-save-space

Conversation

@Akkadius
Copy link
Copy Markdown
Contributor

Description

This PR saves a bunch of space in player event data because we recently started writing augment ids and names in a lot of events even if they are zero a majority of the time. This adds up tremendously for certain events.

See this simple gist as a great example

Type of change

  • Optimization

Testing

Below is an event where we record one augment on summon and an item summon with no aug. (Works both ways)

image

image

Checklist

  • I have tested my changes
  • I have performed a self-review of my code. Ensuring variables, functions and methods are named in a human-readable way, comments are added only where naming of variables, functions and methods can't give enough context.
  • I own the changes of my code and take responsibility for the potential issues that occur

Copy link
Copy Markdown
Contributor

@joligario joligario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joligario joligario merged commit c3f2708 into master Jun 25, 2025
2 checks passed
@joligario joligario deleted the akkadius/player-event-save-space branch June 25, 2025 00:14
@Akkadius Akkadius mentioned this pull request Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants