Skip to content

[Logs] Fix output for tasks in logs#4907

Merged
Akkadius merged 1 commit intomasterfrom
tasks-npc_entity
Jun 9, 2025
Merged

[Logs] Fix output for tasks in logs#4907
Akkadius merged 1 commit intomasterfrom
tasks-npc_entity

Conversation

@joligario
Copy link
Copy Markdown
Contributor

Description

Fixes an issue where the wrong NPC ID and NPC Name were exported during TASK_ACCEPT. The NPC ID was actually the NPC Entity ID and the NPC Name was the player's name.
image
image

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Testing

Individual task data correctly exported:
image

Shared task data correctly exported:
image

Both standard and shared tasks accepted and loaded:
image

Clients tested: RoF2

Checklist

  • I have tested my changes
  • I have performed a self-review of my code. Ensuring variables, functions and methods are named in a human-readable way, comments are added only where naming of variables, functions and methods can't give enough context.
  • I own the changes of my code and take responsibility for the potential issues that occur

@joligario joligario marked this pull request as ready for review May 26, 2025 04:37
@Akkadius Akkadius requested a review from hgtw May 26, 2025 05:31
@Akkadius Akkadius merged commit 687d109 into master Jun 9, 2025
2 checks passed
@Akkadius Akkadius deleted the tasks-npc_entity branch June 9, 2025 17:32
@Akkadius Akkadius mentioned this pull request Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants