Skip to content

[Logging] Auto Update Log Category Names#4890

Merged
Akkadius merged 1 commit intomasterfrom
akkadius/auto-update-log-category-names
May 16, 2025
Merged

[Logging] Auto Update Log Category Names#4890
Akkadius merged 1 commit intomasterfrom
akkadius/auto-update-log-category-names

Conversation

@Akkadius
Copy link
Copy Markdown
Contributor

@Akkadius Akkadius commented May 16, 2025 •
edited
Loading

Description

This PR alleviates a scenario where you have drift in your logging category descriptions from what is declared in the source. Maybe you had local logging categories defined and all of a sudden you merged in some newer ones and it shifted your ID's. This keeps everything consistent.

Type of change

  • New feature (non-breaking change which adds functionality)

Testing

On bootup of zone, different category name is detected and updated.

  Zone |    Info    | LoadLogDatabaseSettings Updating log category [Packet-S->C] (83) to new name [Packet S->C] 
  Zone |    Info    | LoadLogDatabaseSettings Updating log category [Packet-C->S] (84) to new name [Packet C->S] 
  Zone |    Info    | LoadLogDatabaseSettings Updating log category [Packet-S->S] (85) to new name [Packet S->S] 
  Zone |    Info    | LoadLogDatabaseSettings Updating log category [ffffff] (100) to new name [NpcHandin]
  Zone |    Info    | LoadLogDatabaseSettings Updating log category [QueryErr] (35) to new name [MySQL Error] 
  Zone |    Info    | LoadLogDatabaseSettings Updating log category [Query] (36) to new name [MySQL Query] 
  Zone |    Info    | LoadLogDatabaseSettings Updating log category [MobAppearance] (52) to new name [Mob Appearance] 
  Zone |    Info    | LoadLogDatabaseSettings Updating log category [AI Scan] (59) to new name [AI Scan Close] 
  Zone |    Info    | LoadLogDatabaseSettings Updating log category [AI Yell] (60) to new name [AI Yell For Help] 
  Zone |    Info    | LoadLogDatabaseSettings Updating log category [ChecksumVer] (78) to new name [Checksum Verification]

Checklist

  • I have tested my changes
  • I have performed a self-review of my code. Ensuring variables, functions and methods are named in a human-readable way, comments are added only where naming of variables, functions and methods can't give enough context.
  • I own the changes of my code and take responsibility for the potential issues that occur

@Akkadius Akkadius merged commit ec31fdd into master May 16, 2025
2 checks passed
@Akkadius Akkadius deleted the akkadius/auto-update-log-category-names branch May 16, 2025 18:39
@Akkadius Akkadius mentioned this pull request May 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joligario joligario joligario approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Akkadius @joligario