Skip to content

[Crash] Fix crash bug with pbae and quest scripts spawning mobs#4884

Merged
Akkadius merged 1 commit intoEQEmu:masterfrom
carolus21rex:patch-9
May 15, 2025
Merged

[Crash] Fix crash bug with pbae and quest scripts spawning mobs#4884
Akkadius merged 1 commit intoEQEmu:masterfrom
carolus21rex:patch-9

Conversation

@carolus21rex
Copy link
Copy Markdown
Contributor

@carolus21rex carolus21rex commented May 10, 2025

Description

If a PBAE is in progress while a mob pops it can cause a crash. Forcing a copy before the ae has a chance to pop a mob fixed the weirdness in my testing.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@carolus21rex
Fix crash bug with pbae and quest scripts spawning mobs
3c8f117 
If a PBAE is in progress while a mob pops it can cause a crash. Forcing a copy before the ae has a chance to pop a mob should fix the weirdness
@Veruca1
Copy link
Copy Markdown

Veruca1 commented May 10, 2025

Ty Caro again

Barathos
Barathos approved these changes May 12, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Barathos Barathos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Been running this a few days now and seems to have resolved a good bit of zone crashing issues we had going on. (Bemvaras) - Shadowed Eclipse server

@Akkadius Akkadius changed the title Fix crash bug with pbae and quest scripts spawning mobs [Crash] Fix crash bug with pbae and quest scripts spawning mobs May 15, 2025
Akkadius
Akkadius approved these changes May 15, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Akkadius Akkadius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely convinced this fixes anything but it is a rather harmless change so I will approve for now and push it through.

It would be good to attach the crash stack associated with the fix as well.

Thank you for submitting

@Akkadius Akkadius merged commit 21bd906 into EQEmu:master May 15, 2025
1 check passed
@carolus21rex
Copy link
Copy Markdown
Contributor Author

carolus21rex commented May 15, 2025 •
edited
Loading 

C:\Windows\Temp\drone-XpvPblnQiZ3eRn3D\drone\src\zone\effects.cpp (1130): EntityList::AESpell 
C:\Windows\Temp\drone-XpvPblnQiZ3eRn3D\drone\src\zone\spells.cpp (2645): Mob::SpellFinished 
C:\Windows\Temp\drone-XpvPblnQiZ3eRn3D\drone\src\zone\mob.cpp (5399): Mob::ExecWeaponProc 
C:\Windows\Temp\drone-XpvPblnQiZ3eRn3D\drone\src\zone\attack.cpp (5081): Mob::TryWeaponProc 
C:\Windows\Temp\drone-XpvPblnQiZ3eRn3D\drone\src\zone\attack.cpp (5002): Mob::TryCombatProcs 
C:\Windows\Temp\drone-XpvPblnQiZ3eRn3D\drone\src\zone\bot.cpp (2435): Bot::AI_Process 
C:\Windows\Temp\drone-XpvPblnQiZ3eRn3D\drone\src\zone\bot.cpp (1779): Bot::Process 
C:\Windows\Temp\drone-XpvPblnQiZ3eRn3D\drone\src\zone\entity.cpp (544): EntityList::MobProcess 
C:\Windows\Temp\drone-XpvPblnQiZ3eRn3D\drone\src\zone\main.cpp (635): `main'::`2'::<lambda_1>::operator() 
C:\Windows\Temp\drone-XpvPblnQiZ3eRn3D\drone\src\common\event\timer.h (39): `EQ::Timer::Start'::`8'::<lambda_1>::<lambda_invoker_cdecl> 
C:\Windows\Temp\drone-XpvPblnQiZ3eRn3D\drone\src\submodules\libuv\src\timer.c (178): uv__run_timers 
C:\Windows\Temp\drone-XpvPblnQiZ3eRn3D\drone\src\submodules\libuv\src\win\core.c (605): uv_run 
C:\Windows\Temp\drone-XpvPblnQiZ3eRn3D\drone\src\zone\main.cpp (669): main

This is the crash stack. I set up a dev box for it and screwed around with fixing it for about an hour. Shockingly copying the unordered map made it stop checking the npcs nearby in real time. 0 idea why it worked that way but it should also solve an infinite loop zone crash caused by enemies spawning themselves during a pbae

@Akkadius Akkadius mentioned this pull request May 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@Akkadius Akkadius Akkadius approved these changes

@Barathos Barathos Barathos approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@carolus21rex @Veruca1 @Akkadius @Barathos