Skip to content

[Fix] Fix breaking change to UF patches caused by Big Bags update#4883

Merged
Akkadius merged 4 commits intoEQEmu:masterfrom
hbingram:master
May 15, 2025
Merged

[Fix] Fix breaking change to UF patches caused by Big Bags update#4883
Akkadius merged 4 commits intoEQEmu:masterfrom
hbingram:master

Conversation

@hbingram
Copy link
Copy Markdown
Contributor

@hbingram hbingram commented May 9, 2025

Description

Fixed breaking changes in UF patches caused by the Big Bags update. I'm using UF opcode set for Adventure MMO.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Testing

Tested GENERAL_BAGS, CURSOR_BAG, BANK_BAGS, BANK_SHARED_BAGS, and TRADE_BAGS.

Clients tested:

Tested with custom client / Adventure MMO.

Checklist

  • I have tested my changes
  • I have performed a self-review of my code. Ensuring variables, functions and methods are named in a human-readable way, comments are added only where naming of variables, functions and methods can't give enough context.
  • I own the changes of my code and take responsibility for the potential issues that occur

@Akkadius Akkadius changed the title Fix breaking change to UF patches caused by Big Bags update [Fix] Fix breaking change to UF patches caused by Big Bags update May 15, 2025
Copy link
Copy Markdown
Contributor

@Akkadius Akkadius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the initiative to fix this @hbingram and paying it forward.

In the future please fill the PR template form completely. Attach testing illustrating slot translations are working for example.

Approved

@Akkadius Akkadius merged commit 24f8d88 into EQEmu:master May 15, 2025
1 check passed
@Akkadius Akkadius mentioned this pull request May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants