Skip to content

[Fix] Prevent Ranged Attack from being triggered at arbitrary rate#4879

Merged
Akkadius merged 1 commit intomasterfrom
unknown repository
May 15, 2025
Merged

[Fix] Prevent Ranged Attack from being triggered at arbitrary rate#4879
Akkadius merged 1 commit intomasterfrom
unknown repository

Conversation

@catapultam-habeo
Copy link
Copy Markdown
Contributor

@catapultam-habeo catapultam-habeo commented May 8, 2025

Description

If OP_CombatAbility triggers a Ranged Attack, it can bypass the ranged attack timer. This is normally rate limited by client, though client does calculate the speed incorrectly at high haste values - allowing the 'ranged attack' button to be pressed faster than the autofire timer. However, this could be more seriously exploited by a MQ2 plugin which sends the appropriate packet at any arbitrary rate.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Testing

Deployed to THJ

Clients tested:
ROF2

Checklist

  • I have tested my changes
  • I have performed a self-review of my code. Ensuring variables, functions and methods are named in a human-readable way, comments are added only where naming of variables, functions and methods can't give enough context.
  • I own the changes of my code and take responsibility for the potential issues that occur

Copy link
Copy Markdown
Contributor

@Akkadius Akkadius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you sir

@Akkadius Akkadius changed the title [Bug Fix] Prevent Ranged Attack from being triggered at arbitrary rate [Fix] Prevent Ranged Attack from being triggered at arbitrary rate May 15, 2025
@Akkadius Akkadius merged commit f3697e6 into EQEmu:master May 15, 2025
1 check passed
@Akkadius Akkadius mentioned this pull request May 15, 2025
@catapultam-habeo catapultam-habeo deleted the ranged_attack_timer branch May 21, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants