Description

The existing Character:TradeskillUp* rules can be misleading. There's two checks to see whether you increase your skill in a particular trade, and the second check does not have any sort of rule associated with it.

This PR adds Character:TradeskillUpMinChance, which is the minimum chance to gain a tradeskill, and it affects both the first and second stage checks. This would allow servers (specifically THJ) to make it easier on players to do tradeskills.

I originally submitted this PR to THJ directly and was asked to consider upstreaming it.

Type of change

• New feature (non-breaking change which adds functionality)

Testing

Clients tested: akkstack/ROF2

Checklist

• I have tested my changes
• I have performed a self-review of my code. Ensuring variables, functions and methods are named in a human-readable way, comments are added only where naming of variables, functions and methods can't give enough context.
• I own the changes of my code and take responsibility for the potential issues that occur