Skip to content

[Performance] Store Player Title Sets in Client Memory#4836

Merged
Akkadius merged 9 commits intomasterfrom
performance/player_title_sets_memory
May 15, 2025
Merged

[Performance] Store Player Title Sets in Client Memory#4836
Akkadius merged 9 commits intomasterfrom
performance/player_title_sets_memory

Conversation

@Kinglykrab
Copy link
Copy Markdown
Contributor

@Kinglykrab Kinglykrab commented Apr 3, 2025 •
edited
Loading

Description

  • Stores player title sets in client memory, loading them when a player zones in, instead of having an individual query per title.
  • Testing shows no queries being ran, but server is aware the player has the proper title sets.

Type of change

  • New feature

Testing

image
image
image

Checklist

  • I have tested my changes
  • I have performed a self-review of my code. Ensuring variables, functions and methods are named in a human-readable way, comments are added only where naming of variables, functions and methods can't give enough context.
  • I own the changes of my code and take responsibility for the potential issues that occur

@Kinglykrab Kinglykrab changed the title [Performance] Store Player Title Sets in Zone Memory [Performance] Store Player Title Sets in Client Memory Apr 3, 2025
Akkadius
Akkadius reviewed Apr 3, 2025
View reviewed changes
Akkadius
Akkadius reviewed Apr 10, 2025
View reviewed changes
@Akkadius
Copy link
Copy Markdown
Contributor

Akkadius commented Apr 10, 2025

So I think this is most of the way there, your work on titles has been amazing. The titles code was extremely convoluted and now it is much better.

Client::AddTitle and Client::EnableTitle seems functionally the exact same, it would be good to consolidate them both.

SaveCharacterTitleSets also seems no longer needed.

After those adjustments and another round of testing we should be good to go <3

@Kinglykrab
Copy link
Copy Markdown
Contributor Author

Kinglykrab commented Apr 10, 2025

So I think this is most of the way there, your work on titles has been amazing. The titles code was extremely convoluted and now it is much better.

Client::AddTitle and Client::EnableTitle seems functionally the exact same, it would be good to consolidate them both.

SaveCharacterTitleSets also seems no longer needed.

After those adjustments and another round of testing we should be good to go <3

Reran testing, seems to be just fine with the changes.

@Akkadius Akkadius merged commit c36c336 into master May 15, 2025
2 checks passed
@Akkadius Akkadius deleted the performance/player_title_sets_memory branch May 15, 2025 01:46
@Akkadius Akkadius mentioned this pull request May 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Akkadius Akkadius Akkadius approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Kinglykrab @Akkadius