Skip to content

[Bots] Correct ^pull logic and add checks for Enchanter pets#4827

Merged
Akkadius merged 7 commits intoEQEmu:masterfrom
nytmyr:bot-pull-fix
May 15, 2025
Merged

[Bots] Correct ^pull logic and add checks for Enchanter pets#4827
Akkadius merged 7 commits intoEQEmu:masterfrom
nytmyr:bot-pull-fix

Conversation

@nytmyr
Copy link
Copy Markdown
Contributor

@nytmyr nytmyr commented Mar 31, 2025

Description

  • Removed initial LoS check from bots and rely only on owner when told to ^pull. This prevents bots from getting stuck in a loop if they don't have LoS when trying to initiate the pull.
  • Fixed Animation Empathy checks and consolidates.
  • Enchanter pets will honor Animation Empathy rules all around.
  • Pets will properly guard if allowed when pulling.
  • Adds additional checks to ensure pulls go properly and abort properly.
  • Uses tiered checks when within range to do the appropriate attack (Archery->Spell AI->Pull Spell [Throw Stone by default])

Bot Pull Bug

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Testing

  • Verified LoS scenarios and different types of pulling with bots.
  • Verified Enchanter pets are only controllable when applicable (proper ranked of Animation Empathy).
  • Verified Pet guards properly on pulls and releases guard on return.

Clients tested: RoF2

Checklist

  • I have tested my changes
  • I have performed a self-review of my code. Ensuring variables, functions and methods are named in a human-readable way, comments are added only where naming of variables, functions and methods can't give enough context.
  • I own the changes of my code and take responsibility for the potential issues that occur

nytmyr added 5 commits March 31, 2025 16:07
- Removed initial LoS check from bots and rely only on owner when told to ^pull. This prevents bots from getting stuck in a loop if they don't have LoS when trying to initiate the pull.
- Bots previously weren't checking if they were in a valid state or not before trying to click an item when told (in a death state, held, feared, silenced, in group/raid, etc.)
- Bots previously weren't checking if they were in a valid state or not before trying to click an item when told (in a death state, held, feared, silenced, in group/raid, etc.)

Miscommit
- Cleanup
- Fixed Animation Empathy checks and consolidates
- Enchanter pets will honor Animation Empathy rules all around
- Pets will properly guard if allowed when pulling
@nytmyr nytmyr changed the title [Bots] Fix bots getting stuck on ^pull [Bots] Correct ^pull logic and add checks for Enchanter pets Apr 11, 2025
@Akkadius Akkadius merged commit a2b28b2 into EQEmu:master May 15, 2025
1 check passed
@Akkadius Akkadius mentioned this pull request May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants