[Repositories] Explicitly pass database pointers to repository methods#1225
Merged
[Repositories] Explicitly pass database pointers to repository methods#1225
Conversation
hgtw
approved these changes
Feb 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change comes as a result of some user feedback and some of my own experience as I've been using repositories in code
The original intent of a repository method was to make it as intuitive and simple to use as possible so the generation made assumptions about what database pointer it should use under the hood
databaseorcontent_db.This all works fine and dandy, however this pattern breaks down as soon as we want to use a repository in any shared
./commonlogic. The reason for this is our poorly distributed Database logic. For world and zone we have separate classes tied to pointersdatabaseandcontent_dbso we cannot use shared type signatures and make assumptions within the repository methodsFor this reason, these assumptions and attempts to simplify usage of repositories are outweighed by the annoyances of not being able to use them in any
./commonshared logic which is a very common use caseThis PR implements explicitly passing in database pointers into repository methods and updates all of the referenced places in the code where its used