This repository was archived by the owner on Aug 2, 2022. It is now read-only.
Webpack separating external packages and cross-platform building#827
Merged
Webpack separating external packages and cross-platform building#827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Webpack has been packaging external packages with eosjs and there is a requirement to ensure that these external packages are separated in a different file. Additionally, webpack and tsc needed deletion of the files before they run and we were using rm -rf which is not crossplatform. Webpack has a plugin that can clean a directory but for tsc, I added rimraf, a cross-platform package for this use case.
Since the vendor files have been moved to
externals.jsandexternals.min.js, these files must be included when using eosjs in the browser going forward.API Changes
Documentation Additions
Added a note that
externals.jsorexternals.min.jsare now required to be added in order to use eosjs