Skip to content
This repository was archived by the owner on Aug 2, 2022. It is now read-only.

add bn.js as explicit dependency#777

Merged
jeffreyssmith2nd merged 3 commits intoEOSIO:developfrom
faustbrian:bnjs-yarn-berry
Jul 20, 2020
Merged

add bn.js as explicit dependency#777
jeffreyssmith2nd merged 3 commits intoEOSIO:developfrom
faustbrian:bnjs-yarn-berry

Conversation

@faustbrian
Copy link
Copy Markdown
Contributor

@faustbrian faustbrian commented Jul 16, 2020

Trying to install eosjs with certain package managers like yarn berry or ones that use a strict validation mode will fail because bn.js is an implicit dependency and relying on implicit dependencies is generally bad practice and error-prone.

    eosjs tried to access bn.js, but it isn't declared in its dependencies; this makes the require call ambiguous and unsound.

    Required package: bn.js (via "bn.js")
    Required by: eosjs@npm:21.0.2 (via /home/runner/work/platform-sdk/platform-sdk/.yarn/cache/eosjs-npm-21.0.2-047daf3463-2.zip/node_modules/eosjs/dist/)

@jeffreyssmith2nd
Copy link
Copy Markdown
Contributor

jeffreyssmith2nd commented Jul 16, 2020

Thanks for the PR! Can you retarget it to the develop branch?

@faustbrian faustbrian changed the base branch from master to develop July 16, 2020 12:25
@faustbrian
Copy link
Copy Markdown
Contributor Author

faustbrian commented Jul 16, 2020

@jeffreyssmith2nd changed the target branch

jeffreyssmith2nd
jeffreyssmith2nd reviewed Jul 16, 2020
View reviewed changes
@faustbrian faustbrian mentioned this pull request Jul 17, 2020
Merged
@faustbrian
Copy link
Copy Markdown
Contributor Author

faustbrian commented Jul 17, 2020

Until this is merged and released people can use the following .yarnrc.yml as a workaround if they use yarn berry. This requires you to do yarn add bn.js to add bn.js as a dependency of your own project.

packageExtensions:
  "eosjs@*":
    dependencies:
      "bn.js": "^5.1.2"

@jeffreyssmith2nd jeffreyssmith2nd merged commit dbae270 into EOSIO:develop Jul 20, 2020
@faustbrian faustbrian deleted the bnjs-yarn-berry branch July 20, 2020 13:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@jeffreyssmith2nd jeffreyssmith2nd jeffreyssmith2nd approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bradlhart bradlhart

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@faustbrian @jeffreyssmith2nd @bradlhart