This repository was archived by the owner on Aug 2, 2022. It is now read-only.
Remove unnecessary call to get_block_header_state (release/21.0.x branch)#747
Merged
bradlhart merged 3 commits intorelease/21.0.xfrom Jun 9, 2020
Merged
Remove unnecessary call to get_block_header_state (release/21.0.x branch)#747bradlhart merged 3 commits intorelease/21.0.xfrom
bradlhart merged 3 commits intorelease/21.0.xfrom
Conversation
jeffreyssmith2nd
approved these changes
Jun 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Calls to
get_block_header_stateproduce errors when calling against a block that is not reversible. This PR reduces the need for those calls.API Changes
Don't call
get_block_header_statewhenever possible ontransact.Documentation Additions
Fixes #702
Co-Authored By: @UMU618 umu618@hotmail.com