This repository was archived by the owner on Aug 2, 2022. It is now read-only.
eosjs-ecc methods and migration (release/21.0.x branch)#709
Merged
bradlhart merged 12 commits intorelease/21.0.xfrom Apr 1, 2020
Merged
eosjs-ecc methods and migration (release/21.0.x branch)#709bradlhart merged 12 commits intorelease/21.0.xfrom
bradlhart merged 12 commits intorelease/21.0.xfrom
Conversation
added 12 commits
March 13, 2020 09:37
jeffreyssmith2nd
approved these changes
Mar 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Following feedback and requests, the ecc helper functions have been renamed to match the
eosjs-eccmethods where possible. A private key generation method has also been added, as well as aPublicKey.toLegacyString()method for backwards compatibility.Lastly, an
eccexported object is available with all the functionseosjs-ecchas that utilizes the new functions.Second PR to cherry pick commits to release/21.0.x branch
API Changes
Changed:
sign,verify, andrecovernow have the argumentshouldHashthat by default is set totrue. These functions will hash the data given but can accept already hashed data withshouldHash=falsePublicKey.validatewas renamed toPublicKey.isValidSignature.recoverPublicKeywas renamed toSignature.recoverNew:
PrivateKey.toLegacyString: Convert private key to Legacy EOSIO-format private keyPrivateKey.isValid: Validate a private keyPublicKey.toLegacyString: Convert public key to Legacy EOSIO-format public keygenerateKeyPair: Utilizes theellipticpackage to generate a public and private key pair. This function should only be used in secure environments and requires an environment variable to be set to confirm that the environment is secure.sha256: An exported sha256 function from theellipticpackageDocumentation Additions