This repository was archived by the owner on Aug 2, 2022. It is now read-only.
Conversation
| // These didn't test the correctness of signing. They also depend on the now-removed eosjs-ecc. | ||
|
|
||
| it('builds public keys from private when constructed', async () => { | ||
| /* |
Contributor
There was a problem hiding this comment.
Rather than commenting out, I'd suggest just going ahead and deleting them.
Semi-related, if these tests didn't actually test the correctness it would be nice to see tests that do test the correctness.
c0d3ster
approved these changes
Aug 9, 2019
Contributor
c0d3ster
left a comment
There was a problem hiding this comment.
Agree that we should have tests for the webauthn and changes to signature provider prior to the next release, but I won't block the PR since you need this to move forward
src/eosjs-numeric.ts
Outdated
| throw new Error('unrecognized private key format'); | ||
| // todo: Verify checksum: sha256(sha256(key.data)). | ||
| // Not critical since a bad key will fail to produce an | ||
| // invalid signature anyway. |
Contributor
There was a problem hiding this comment.
Should be "fail to produce valid signature"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
API Changes
Documentation Additions