Skip to content
This repository was archived by the owner on Aug 2, 2022. It is now read-only.

Add support for send_transaction JSON RPC#545

Merged
c0d3ster merged 2 commits intoEOSIO:developfrom
conr2d:support-send_transaction
Jul 3, 2019
Merged

Add support for send_transaction JSON RPC#545
c0d3ster merged 2 commits intoEOSIO:developfrom
conr2d:support-send_transaction

Conversation

@conr2d
Copy link
Copy Markdown
Contributor

@conr2d conr2d commented May 2, 2019

Change Description

Add send_transaction to JSON RPC. Fixes #539.

API Changes

  • API Changes
    send_transaction API is added to a set of supported JSON RPC.

Documentation Additions

  • Documentation Additions
    Newly supported send_transaction needs to be documented with returned format. Legacy API push_transaction has overhead to convert returned data for backward compatibility.

@c0d3ster
Copy link
Copy Markdown
Contributor

c0d3ster commented Jul 3, 2019

Looks good, I simply removed the new interface that you added before merging. Since it is structured the exact same as the old PushTransactionArgs, we can just use those instead.

Copy link
Copy Markdown
Contributor

@c0d3ster c0d3ster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@c0d3ster c0d3ster merged commit 9ee5235 into EOSIO:develop Jul 3, 2019
@c0d3ster c0d3ster mentioned this pull request Jul 3, 2019
@conr2d conr2d deleted the support-send_transaction branch July 4, 2019 01:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants