Skip to content
This repository was archived by the owner on Aug 2, 2022. It is now read-only.

add get_table_by_scope to eosjs#514

Merged
jeffreyssmith2nd merged 2 commits intoEOSIO:developfrom
meet-one:get-table-by-scope
Mar 7, 2019
Merged

add get_table_by_scope to eosjs#514
jeffreyssmith2nd merged 2 commits intoEOSIO:developfrom
meet-one:get-table-by-scope

Conversation

@wuyahuang
Copy link
Copy Markdown
Contributor

@wuyahuang wuyahuang commented Mar 6, 2019

@jeffreyssmith2nd
Copy link
Copy Markdown
Contributor

This looks great, thanks for contributing! Before merging, can you add a test for this new function similar to the one for get_table_rows? https://github.com/EOSIO/eosjs/blob/develop/src/tests/eosjs-jsonrpc.test.ts#L382

@wuyahuang
Copy link
Copy Markdown
Contributor Author

updated.

@jeffreyssmith2nd
Copy link
Copy Markdown
Contributor

Great work, thanks!

@jeffreyssmith2nd jeffreyssmith2nd merged commit ac84c38 into EOSIO:develop Mar 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants