Skip to content
This repository was archived by the owner on Aug 2, 2022. It is now read-only.

add optional sign parameter to transact function#432

Merged
tbfleming merged 3 commits intoEOSIO:developfrom
indiev:selective-sign-transact
Nov 19, 2018
Merged

add optional sign parameter to transact function#432
tbfleming merged 3 commits intoEOSIO:developfrom
indiev:selective-sign-transact

Conversation

@indiev
Copy link
Copy Markdown
Contributor

@indiev indiev commented Nov 14, 2018

No description provided.

@indiev indiev changed the title add selective sign parameter to transact function add optional sign parameter to transact function Nov 14, 2018
@tbfleming
Copy link
Copy Markdown
Contributor

What are you trying to accomplish? After this patch, if sign is false the function does nothing and returns nothing.

@indiev
Copy link
Copy Markdown
Contributor Author

indiev commented Nov 17, 2018

@tbfleming When sign is false, only serializedTransaction without signatures is returned.
It is used to create transaction object for msig(multi sig).

@tbfleming
Copy link
Copy Markdown
Contributor

Ok. I see it now. Please make the following changes:

  • signatures should be a required member of PushTransactionArgs
  • For this case, set signatures to []
  • Remove the extra empty lines
  • Bug: const pushTransactionArgs = should be pushTransactionArgs =

@indiev
Copy link
Copy Markdown
Contributor Author

indiev commented Nov 18, 2018

oh, i got it. i pushed commit about changes

@tbfleming tbfleming merged commit b5394ce into EOSIO:develop Nov 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants