This repository was archived by the owner on Aug 2, 2022. It is now read-only.
use native textEncoder/Decoder#382
Merged
tbfleming merged 2 commits intoEOSIO:masterfrom Oct 26, 2018
Merged
Conversation
'text-encoding' npm package is no longer maintained and the node native implementation is available since 8.3 https://nodejs.org/api/util.html#util_class_util_textencoder https://nodejs.org/api/util.html#util_class_util_textdecoder I would suggest that this package should automatically import and use these native functions when it detects that it's being run in node. Manual import should only be necessary if you need to override this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
'text-encoding' npm package is no longer maintained and the node native implementation is available since 8.3
https://nodejs.org/api/util.html#util_class_util_textencoder
https://nodejs.org/api/util.html#util_class_util_textdecoder
I would suggest that this package should automatically import and use these native functions when it detects that it's being run in node. Manual import should only be necessary if you need to override this.