This repository was archived by the owner on Aug 2, 2022. It is now read-only.
Support proper spec compliant call_indirect wast syntax#1366
Merged
wanderingbort merged 1 commit intomasterfrom Feb 12, 2018
Merged
Support proper spec compliant call_indirect wast syntax#1366wanderingbort merged 1 commit intomasterfrom
wanderingbort merged 1 commit intomasterfrom
Conversation
The wasm spec has a different definition for the call_indirect syntax in textual representation then what we currently support. Add code to support the spec’s syntax as newer binaryen (s2wasm) seems to use the spec’s syntax. Be aware, this might still not be TECHNICALLY to spec — I think the spec may allow for defining the function prototype right at the call_indirect site. We only support usage of a type name or type index at the call_indirect site.
wanderingbort
approved these changes
Feb 12, 2018
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wasm spec has a different definition for the call_indirect syntax in textual representation then what we currently support. Add code to support the spec’s syntax as newer binaryen (s2wasm) seems to use the spec’s syntax.
Be aware, this might still not be TECHNICALLY to spec — I think the spec may allow for defining the function prototype right at the call_indirect site. We only support usage of a type name or type index at the call_indirect site.
Fixes issue #1355