internal/providers/xai/xai_test.go (1)

649-671: 🧹 Nitpick | 🔵 Trivial

checkStream doesn't assert the response.completed event it is testing.

The mock response body at Lines 643–644 now emits response.completed, but the checkStream closure only asserts response.created, response.output_text.delta, and [DONE]. Adding a check for response.completed makes the test actually verify the renamed event survives the passthrough.

✅ Suggested addition

 if !strings.Contains(responseStr, "[DONE]") {
 	t.Error("response should end with [DONE]")
 }
+if !strings.Contains(responseStr, "response.completed") {
+	t.Error("response should contain response.completed event")
+}

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@internal/providers/xai/xai_test.go` around lines 649 - 671, The test's
checkStream closure (checkStream func(t *testing.T, body io.ReadCloser))
currently asserts response.created, response.output_text.delta and [DONE] but
omits verifying the response.completed event; update the closure to also assert
that the streamed response contains "response.completed" (e.g., add an if
!strings.Contains(responseStr, "response.completed") { t.Error("response should
contain response.completed event") }) so the test confirms the renamed event
passes through.

internal/providers/groq/groq_test.go (1)

580-590: 🧹 Nitpick | 🔵 Trivial

TestStreamResponses missing assertion for response.completed.

TestStreamResponses verifies response.created and response.output_text.delta but does not assert response.completed, leaving the final event untested here. TestGroqResponsesStreamConverter covers this via the converter directly, but TestStreamResponses exercises the full StreamResponses → converter path and should assert the same terminal event for full regression coverage.

✅ Suggested addition

 if !strings.Contains(responseStr, "[DONE]") {
 	t.Error("response should end with [DONE]")
 }
+if !strings.Contains(responseStr, "response.completed") {
+	t.Error("response should contain response.completed event")
+}

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@internal/providers/groq/groq_test.go` around lines 580 - 590, Add an
assertion in TestStreamResponses to check that the streaming output includes the
terminal "response.completed" event: after the existing checks on responseStr
(which currently asserts "response.created", "response.output_text.delta", and
"[DONE]"), add a strings.Contains check for "response.completed" and call
t.Error (or t.Fatalf) if it's missing so the full StreamResponses →
TestGroqResponsesStreamConverter path verifies the terminal event as well.

internal/providers/ollama/ollama_test.go (1)

640-650: 🧹 Nitpick | 🔵 Trivial

TestStreamResponses missing assertion for response.completed.

Same gap as groq/groq_test.go: TestStreamResponses verifies response.created and response.output_text.delta but omits a check for response.completed, leaving the final event untested on the full StreamResponses path.

✅ Suggested addition

 if !strings.Contains(responseStr, "[DONE]") {
 	t.Error("response should end with [DONE]")
 }
+if !strings.Contains(responseStr, "response.completed") {
+	t.Error("response should contain response.completed event")
+}

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@internal/providers/ollama/ollama_test.go` around lines 640 - 650, Add an
assertion in TestStreamResponses to verify the final "response.completed" event
is present: after converting respBody to responseStr (variable responseStr) add
a check using strings.Contains(responseStr, "response.completed") and call
t.Error with a descriptive message if it's missing, mirroring the existing
checks for "response.created" and "response.output_text.delta" to ensure the
full StreamResponses path emits the completed event.

internal/providers/openai/openai_test.go (1)

624-651: ⚠️ Potential issue | 🟡 Minor

Assert response.completed explicitly in stream validation.

The fixture now uses response.completed (Line 624), but checkStream doesn’t assert it. This can let final-event regressions slip through.

Proposed assertion update

 				if !strings.Contains(responseStr, "response.output_text.delta") {
 					t.Error("response should contain response.output_text.delta event")
 				}
+				if !strings.Contains(responseStr, "response.completed") {
+					t.Error("response should contain response.completed event")
+				}
 				if !strings.Contains(responseStr, "[DONE]") {
 					t.Error("response should end with [DONE]")
 				}

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@internal/providers/openai/openai_test.go` around lines 624 - 651, The test's
stream validator (the checkStream closure in the test case) currently asserts
for "response.created", "response.output_text.delta", and "[DONE]" but doesn't
assert the new "response.completed" event; update the checkStream function used
in internal/providers/openai/openai_test.go to also verify that the response
body string contains "response.completed" (e.g., add an assertion that checks
strings.Contains(responseStr, "response.completed") and fails the test if it's
missing) alongside the existing assertions.