fix(gom-41): pre-create data/ dir for nonroot user in Docker image#81
Merged
SantiagoDePolonia merged 2 commits intomainfrom Feb 19, 2026
Merged
Conversation
The distroless nonroot runtime image (UID 65532) cannot create directories under /app at runtime. Pre-create data/ with correct ownership, matching the existing pattern used for .cache/. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 📝 WalkthroughWalkthroughThe Dockerfile now creates both Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@Dockerfile`:
- Line 21: Update the stale Dockerfile comments so they accurately reference
both directories (.cache and data) instead of only .cache: change the comment
that currently reads "Create cache directory for runtime (with placeholder for
COPY)" to mention both ".cache and data" as runtime cache/data directories, and
change "Create writable cache directory for SQLite storage (nonroot user
UID=65532)" to mention that it creates a writable directory for both ".cache and
data" for SQLite/nonroot UID=65532; locate the two comment strings in the
Dockerfile and adjust their text accordingly.
…data dirs Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The distroless nonroot runtime image (UID 65532) cannot create directories under /app at runtime. Pre-create data/ with correct ownership, matching the existing pattern used for .cache/.
Summary by CodeRabbit