internal/server/model_validation_test.go (1)

701-744: 🧹 Nitpick | 🔵 Trivial

Consider asserting RouteHints.Provider for consistency.

The first test (DoesNotCacheCanonicalChatRequestWhenRouteHintsAlreadyExist) asserts both RouteHints.Model and RouteHints.Provider, but this test only asserts RouteHints.Model. Per storeRequestModelResolution (context snippet 2), both fields are populated after resolution.

Since the body doesn't include a provider field, you could either:

1. Add "provider":"openai" to the body and assert it matches, or
2. Assert the expected default/resolved provider value

This would make the test more complete and consistent with the chat request test pattern.

Option 1: Add provider to body and assert

 	frame := core.NewRequestSnapshot(
 		http.MethodPost,
 		"/v1/responses",
 		nil,
 		nil,
 		nil,
 		"application/json",
 		[]byte(`{
 			"model":"gpt-4o-mini",
+			"provider":"openai",
 			"input":[{"type":"message","role":"user","content":"hi","x_trace":{"id":"trace-1"}}]
 		}`),
 		false,
 		"",
 		nil,
 	)

Then add assertion:

 	assert.Nil(t, capturedEnv.CachedResponsesRequest())
 	assert.Equal(t, "gpt-4o-mini", capturedEnv.RouteHints.Model)
+	assert.Equal(t, "openai", capturedEnv.RouteHints.Provider)

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@internal/server/model_validation_test.go` around lines 701 - 744, Test
TestModelValidation_DoesNotCacheCanonicalResponsesRequestWhenRouteHintsAlreadyExist
is missing an assertion for RouteHints.Provider; update the test (in the
function
TestModelValidation_DoesNotCacheCanonicalResponsesRequestWhenRouteHintsAlreadyExist)
to also assert the resolved provider on capturedEnv.RouteHints.Provider: either
add "provider":"openai" to the JSON body so the handler/ExecutionPlanning
resolution (storeRequestModelResolution / core.DeriveWhiteBoxPrompt) sets it
explicitly and assert that value, or keep the body as-is and assert the expected
default resolved provider (e.g., "openai") on capturedEnv.RouteHints.Provider to
match the other test that checks both Model and Provider.