Walkthrough

Refactors circuit breaker from simple Allow check to an acquire-based approach returning (bool, bool) indicating permission and half-open probe status. Implements probe short-circuiting in DoRaw and retry logic to prevent concurrent probes during open states. Adds comprehensive tests for retry-circuit-breaker interactions and half-open probe behavior.

Changes

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant CB as CircuitBreaker
    participant Retry
    participant Upstream

    Client->>CB: acquire()
    alt Circuit Open (Half-Open Probe)
        CB-->>Client: (true, true)<br/>allowed=true, isProbe=true
        Client->>Upstream: send request
        Upstream-->>Client: error/status
        Client->>Retry: check if retryable
        alt Retryable + In Probe
            Retry->>Client: invoke end-hook<br/>return last error
        end
    else Circuit Closed
        CB-->>Client: (true, false)
        Client->>Upstream: send request
        Upstream-->>Client: response
        alt Failure + Retryable
            Client->>Retry: attempt retry
            Retry->>CB: acquire()
            CB-->>Retry: (allow, probe)
        end
    else Circuit Open (Blocked)
        CB-->>Client: (false, _)
        Client->>Client: invoke end-hook<br/>return last error
    end

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Poem

🐰 A circuit breaker stands so tall,
With half-open probes that heed the call,
No retries when the probe takes flight,
State transitions done just right,
Control flow dancing left and right! 🔌

❌ Failed checks (1 warning)

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

• X
• Mastodon
• Reddit
• LinkedIn

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.