fix: fixed issues based on the code review

SantiagoDePolonia · SantiagoDePolonia · commit c082703e85bb · 2026-01-14T18:40:04.000+01:00
diff --git a/internal/auditlog/auditlog_test.go b/internal/auditlog/auditlog_test.go
@@ -4,6 +4,7 @@ import (
 	"bytes"
 	"context"
 	"encoding/json"
+	"fmt"
 	"io"
 	"strings"
 	"sync"
@@ -244,7 +245,7 @@ func TestLogger(t *testing.T) {
 	// Write some entries
 	for i := 0; i < 5; i++ {
 		logger.Write(&LogEntry{
-			ID:        "entry-" + string(rune('0'+i)),
+			ID:        fmt.Sprintf("entry-%d", i),
 			Timestamp: time.Now(),
 			Model:     "test-model",
 		})
diff --git a/internal/storage/sqlite.go b/internal/storage/sqlite.go
@@ -28,17 +28,15 @@ func NewSQLite(cfg SQLiteConfig) (Storage, error) {
 	}
 
 	// Open database with WAL mode and busy timeout
-	// WAL mode allows concurrent reads while writing
 	dsn := fmt.Sprintf("%s?_journal=WAL&_busy_timeout=5000&_synchronous=NORMAL", cfg.Path)
 	db, err := sql.Open("sqlite", dsn)
 	if err != nil {
 		return nil, fmt.Errorf("failed to open SQLite database: %w", err)
 	}
 
-	// Set connection pool settings for SQLite
-	// SQLite doesn't benefit from multiple connections for writes,
-	// but we allow some for concurrent reads
-	db.SetMaxOpenConns(1) // SQLite only allows one writer at a time
+	// Use a single connection to serialize all database access.
+	// This prevents "database is locked" errors at the cost of no concurrent reads.
+	db.SetMaxOpenConns(1)
 	db.SetMaxIdleConns(1)
 
 	// Verify connection
diff --git a/tests/e2e/auditlog_test.go b/tests/e2e/auditlog_test.go
@@ -554,9 +554,11 @@ func TestAuditLogErrorCapture(t *testing.T) {
 		}()
 
 		// Make a request with an unsupported model
-		payload := map[string]interface{}{
-			"model":    "unsupported-model-xyz",
-			"messages": []map[string]string{{"role": "user", "content": "Hello"}},
+		payload := core.ChatRequest{
+			Model: "unsupported-model-xyz",
+			Messages: []core.Message{
+				{Role: "user", Content: "Hello"},
+			},
 		}
 		body, _ := json.Marshal(payload)
 		resp, err := http.Post(serverURL+"/v1/chat/completions", "application/json", bytes.NewReader(body))
