Conversation
No code changes were needed.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the ruff linter from version 0.11.7 to 0.12.10 and fixes all linting issues that arose from the version update. The changes focus on resolving warning-related test assertions and import optimization rules.
- Updates ruff dependency version in pyproject.toml
- Fixes test deprecation warning assertions by adding specific match patterns
- Resolves import-related linting issues by adding noqa comments and reorganizing imports
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Updates ruff version from 0.11.7 to 0.12.10 |
| tests/test_pixel_breath.py | Adds specific match patterns to pytest.warns calls for deprecation warnings |
| tests/test_parameter_tiv.py | Adds specific match patterns to pytest.warns calls for deprecation warnings |
| tests/test_eeli.py | Adds specific match patterns to pytest.warns calls for deprecation warnings |
| tests/test_continuous_data.py | Updates warning handling and adds assertion for no warnings case |
| tests/mixins/test_slicing.py | Adds specific match patterns to pytest.warns calls for user warnings |
| eitprocessing/roi/init.py | Adds noqa comments for import-within-function and dataclass issues |
| eitprocessing/plotting/rate_detection.py | Reorganizes imports to use TYPE_CHECKING pattern |
| eitprocessing/filters/mdn.py | Removes unused import |
| eitprocessing/features/rate_detection.py | Removes TYPE_CHECKING and moves import to top level |
| eitprocessing/features/pixel_breath.py | Adds noqa comment for import-within-function |
| eitprocessing/datahandling/pixelmap.py | Moves import to top level and adds noqa comments |
| eitprocessing/datahandling/mixins/equality.py | Adds noqa comment for dataclass without hash issue |
| eitprocessing/datahandling/loading/init.py | Adds noqa comment for import-within-function |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
238
to
240
| def plotting(self) -> FilterPlotting: | ||
| """Return the plotting class for this filter.""" | ||
| from eitprocessing.plotting.filter import FilterPlotting | ||
|
|
||
| return FilterPlotting() |
There was a problem hiding this comment.
The FilterPlotting import was removed but the class is still being instantiated on line 240. This will cause a NameError at runtime since FilterPlotting is not defined in this scope.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates to ruff 0.12.10 and fixes all issues resulting from the update.