Respiratory and heart rate detection#405
Merged
Conversation
7002199 to
3f8c393
Compare
- add refinement option for estimated frequency - make welch function faster - reduce code duplication - improve documentation - add captures to extract intermediate data
This reverts commit f4b08d7.
3f8c393 to
9f184a7
Compare
Contributor
Author
|
@JulietteFrancovich I have addressed your comments by improving the documentation, improving the warning message, and adding annotations with the estimated rates to the plots. |
9c67730 to
5bf3852
Compare
JulietteFrancovich
approved these changes
Aug 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the respiratory and heart rate detection algorithm.
Compared to earlier versions, this version has a feature to refine the rate based on parabolic interpolation. It shifts the estimated maximum value towards the left or right of the maximum based on the relative height of the points directly to the left and right.
The algorithm includes a plotting feature with examples.
The PR includes a notebook. I will test adding the notebook to the documentation directly.
Tests are written based on available data, as well as simulated data, which tests many combinations of heart and respiratory rates. Note that more tests were run locally, but a smaller set of simulations was committed to reduce testing time on the server.