Fix broken selenium cookie tracker tests.#1205
Merged
cooperq merged 5 commits intoEFForg:masterfrom Feb 27, 2017
Merged
Conversation
059b786 to
49db849
Compare
49db849 to
d5a7c74
Compare
Contributor
Author
|
Rebased. |
Contributor
|
Looks great! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes
tests/selenium/cookie_test.py::CookieTest.test_cookie_tracker_detectionand cleans up the test file. In theory should work on top of #1168, but should probably be re-tested with it when it is merged, or vice-versa.The main issue seemed to be the test was not python3 compatible.