Merged
Conversation
Contributor
|
4.0/4.1の両方の環境にて認可とAPIによるデータの取得までできることを確認しました。
APIでの取得までできましたので、こちら私の環境では発生していないようです。 |
Collaborator
Author
|
@okazy |
4b4fb35 to
e3b7137
Compare
50b108e to
6e21827
Compare
Collaborator
Author
手元の環境固有の問題だったようです |
okazy
approved these changes
Nov 30, 2020
Contributor
okazy
left a comment
There was a problem hiding this comment.
ありがとうございます！4.0/4.1で通るの素晴らしい 👏
6d463ee to
09a0df0
Compare
Contributor
|
composer.jsonのnameを編集しているので4.1ブランチを新しく作成してそちらにマージします。 |
Contributor
|
ありがとうございます！マージしました。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO
4.1 ブランチでプラグインの@Routeアノテーションを認識してくれない4.0 と 4.1 のユニットテストを両立させる術が無いかもkiy0taka/eccube4-test-fixer を使用することで解決